Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] config: support AllowedCN and AllowedHostname through config file #18063

Merged
merged 1 commit into from
May 23, 2024

Conversation

ArkaSaha30
Copy link
Contributor

@ArkaSaha30 ArkaSaha30 commented May 23, 2024

Backport of #17861, resolves #17867.
Blocks v3.5.14 release: #18013
This backport allows setting AllowedCN and AllowedHostname tls fields through config file for peer transport security.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Allow setting AllowedCN and AllowedHostname tls fields through config file for peer transport security.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
@k8s-ci-robot
Copy link

Hi @ArkaSaha30. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ArkaSaha30
Copy link
Contributor Author

cc @jmhbnz @ahrtr

@jmhbnz jmhbnz changed the title [3.5]backport: config: support AllowedCN and AllowedHostname through config file [3.5] config: support AllowedCN and AllowedHostname through config file May 23, 2024
@jmhbnz
Copy link
Member

jmhbnz commented May 23, 2024

/ok-to-test

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good to me, many thanks for helping work towards 3.5.14 release @ArkaSaha30

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @ArkaSaha30

@ahrtr ahrtr merged commit 47c5fb8 into etcd-io:release-3.5 May 23, 2024
26 checks passed
@ivanvc
Copy link
Member

ivanvc commented May 24, 2024

Thanks @ArkaSaha30. I think we're just missing the release note. Can you open a PR to update the CHANGELOG?

@ArkaSaha30
Copy link
Contributor Author

Thanks @ArkaSaha30. I think we're just missing the release note. Can you open a PR to update the CHANGELOG?

Sure, I'll raise a PR to update the CHANGELOG 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

6 participants