tests/robustness: add in compaction checks for prevKV #18158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes issues watch to etcd using PrevKV() and with that, it relies on the property that create events always have prevKV=nil. This commit incorporates that explicit check in the robustness tests. Further, etcd also can have prevKV=nil for any event type in the case of compaction taking place. This commit also adds in that check to ensure we are not changing these invariants. Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
|
oh wait I see my error - will fix in a little bit. |
|
Please ping me when it's ready for review. |
serathius
reviewed
Jun 15, 2024
| // check that without knowing if compaction has run. | ||
| // i.e. for create events, prevKV is nil. | ||
| if event.IsCreate && event.PrevValue != nil { | ||
| lg.Error("prevValue field shold be nil in create event", zap.Int("client", report.ClientID), zap.Any("event", event), zap.Any("previousValue", prevState.KeyValues[event.Key])) |
There was a problem hiding this comment.
Suggested change
| lg.Error("prevValue field shold be nil in create event", zap.Int("client", report.ClientID), zap.Any("event", event), zap.Any("previousValue", prevState.KeyValues[event.Key])) | |
| lg.Error("prevValue field should be nil in create event", zap.Int("client", report.ClientID), zap.Any("event", event), zap.Any("previousValue", prevState.KeyValues[event.Key])) |
serathius
reviewed
Jun 15, 2024
| err = errBrokePrevKV | ||
| } | ||
|
|
||
| // If compaction took place in the previous state, prevKV should be nil for all types of events in the current state: |
There was a problem hiding this comment.
This is not correct. Event generation and compaction are independent processes. They are not serialized by WAL.
Idea that nil prevKV is caused by compaction is correct, but it cannot be validated this way. Hit me up if you want to discuss it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes issues watch to etcd using PrevKV() and with that, it relies on the property that create events always have prevKV=nil. This commit incorporates that explicit check in the robustness tests.
Further, etcd also can have prevKV=nil for any event type in the case of compaction taking place. This commit also adds in that check to ensure we are not changing these invariants.
We can make this change now because compaction support exists in robustness tests: #17833
Towards: #15820
/assign @serathius @siyuanfoundation