Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove robustness presubmits for amd64 arch #18177

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

ArkaSaha30
Copy link
Contributor

@ArkaSaha30 ArkaSaha30 commented Jun 14, 2024

This PR will remove robustness presubmits for both amd64 and arm64 archs, periodics for amd64 arch since it has been migrated to kubernetes/test-infra as prowjobs:

Issue link: #18136

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @ArkaSaha30. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ArkaSaha30
Copy link
Contributor Author

cc @ivanvc @serathius

@k8s-ci-robot k8s-ci-robot added the github_actions Pull requests that update GitHub Actions code label Jun 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (3be7dbe) to head (2702314).
Report is 4 commits behind head on main.

Current head 2702314 differs from pull request most recent head 6ca3b6b

Please upload reports for the commit 6ca3b6b to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files Coverage Δ
server/storage/wal/metrics.go 100.00% <100.00%> (ø)

... and 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18177      +/-   ##
==========================================
- Coverage   68.84%   68.78%   -0.06%     
==========================================
  Files         416      416              
  Lines       35127    35128       +1     
==========================================
- Hits        24183    24164      -19     
- Misses       9547     9560      +13     
- Partials     1397     1404       +7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be7dbe...6ca3b6b. Read the comment docs.

This commit will remove robustness presubmits
for both `amd64` and `arm64` archs, periodics for
`amd64` arch since it has been migrated to test-infra
as prowjobs:
https://github.com/kubernetes/test-infra/blob/master/config/jobs/etcd/etcd-periodics.yaml#L61-L230
https://github.com/kubernetes/test-infra/blob/master/config/jobs/etcd/etcd-presubmits.yaml#L240-L279

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@ivanvc
Copy link
Member

ivanvc commented Jun 14, 2024

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ArkaSaha30.

@ivanvc
Copy link
Member

ivanvc commented Jun 14, 2024

/ok-to-test

@serathius serathius merged commit f01f23d into etcd-io:main Jun 15, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code ok-to-test size/M
Development

Successfully merging this pull request may close these issues.

None yet

5 participants