Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release-3.5 changelog #18178

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

henrybear327
Copy link
Contributor

@henrybear327 henrybear327 commented Jun 14, 2024

Fully address CVE-2023-45288 and fix govulncheck CI check

Reference:
- etcd-io#18170

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (3be7dbe) to head (c9a2eaf).
Report is 4 commits behind head on main.

Current head c9a2eaf differs from pull request most recent head 84c68f3

Please upload reports for the commit 84c68f3 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files Coverage Δ
server/storage/wal/metrics.go 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18178      +/-   ##
==========================================
- Coverage   68.84%   68.80%   -0.04%     
==========================================
  Files         416      416              
  Lines       35127    35128       +1     
==========================================
- Hits        24183    24170      -13     
- Misses       9547     9558      +11     
- Partials     1397     1400       +3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be7dbe...84c68f3. Read the comment docs.

@henrybear327
Copy link
Contributor Author

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @henrybear327.

@ahrtr ahrtr merged commit d09c935 into etcd-io:main Jun 15, 2024
49 checks passed
@henrybear327 henrybear327 deleted the changelog/Fix-govulncheck-CI-check branch June 15, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

5 participants