Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/robustness: fix access of ChoiceWeight #18202

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

MadhavJivrajani
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani commented Jun 18, 2024

Not sure what went wrong here...
The CI for #18181 should have failed or marked a conflict?

Noticed failures first in: #18201

/assign @serathius

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@serathius
Copy link
Member

serathius commented Jun 18, 2024

We don't have a merge queue like in K8s, so we don't test merging PRs together.

@MadhavJivrajani
Copy link
Contributor Author

Makes sense @serathius, thanks. Can we merge this?

@serathius
Copy link
Member

@MadhavJivrajani
Yes, after the tests pass :P

@MadhavJivrajani
Copy link
Contributor Author

Oh LOL yeah, my bad 🙈

@serathius
Copy link
Member

/retest

@serathius serathius merged commit 7dadc32 into etcd-io:main Jun 18, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants