[2024-06-24] Bump dependency updates identified by dependabot

[henrybear327]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.

Summary of actions

• Bumped
  • bump github.com/golangci/golangci-lint from 1.59.0 to 1.59.1
    • build(deps): bump github.com/golangci/golangci-lint from 1.59.0 to 1.59.1 in /tools/mod #18223
  • bump github.com/google/yamlfmt from 0.12.1 to 0.13.0
    • build(deps): bump github.com/google/yamlfmt from 0.12.1 to 0.13.0 in /tools/mod #18222
• Closed (fully indirect)
  • bump github.com/sashamelentyev/usestdlibvars from 1.25.0 to 1.27.0
    • build(deps): bump github.com/sashamelentyev/usestdlibvars from 1.25.0 to 1.27.0 in /tools/mod #18225
  • bump github.com/Antonboom/testifylint from 1.3.0 to 1.4.3
    • build(deps): bump github.com/Antonboom/testifylint from 1.3.0 to 1.4.3 in /tools/mod #18224
  • bump github.com/bombsimon/wsl/v4 from 4.2.1 to 4.4.1
    • build(deps): bump github.com/bombsimon/wsl/v4 from 4.2.1 to 4.4.1 in /tools/mod #18221

[henrybear327]

Passing the dependency update torch to @ArkaSaha30 for the entire July after this one! :)

[henrybear327]

Updating golangci-lint to 1.59.1 generated the following lint issue

FAIL: (code:1):
  % (cd server && golangci-lint run --config /Users/henrybear327/go/src/etcd/tools/.golangci.yaml ./...)
storage/mvcc/kvstore.go:312:27: (*store).restore - result 0 (error) is always nil (unparam)
func (s *store) restore() error {
                          ^
FAIL: 'run golangci-lint run --config /Users/henrybear327/go/src/etcd/tools/.golangci.yaml ./...' checking failed (!=0 return code)
There was a Failure in module server, aborting...
FAIL: 'lint' FAILED at Mon Jun 24 21:48:39 CEST 2024
make: *** [verify-lint] Error 255

Both Attach() and compactLockfree() within the function restore() are able to return an error but we only log them in the current implementation, thus, the return value for error is always nil, hence the linter warning.

@ahrtr do we need to do anything about this? Or we should just suppress the linter warning here :) Thanks

[ahrtr]

@henrybear327 suggest to only suppress the error for now.

Thanks

[henrybear327]

Both Attach() and compactLockfree() within the function restore() are able to return an error but we only log them in the current implementation, thus, the return value for error is always nil, hence the linter warning.

Done as agreed.

[ahrtr]

LGTM

Thanks

[jmhbnz]

LGTM - Thanks @henrybear327

[henrybear327]

@jmhbnz @ahrtr please close the indirect dependency PRs :) Thanks

[ahrtr]

@jmhbnz @ahrtr please close the indirect dependency PRs :) Thanks

I have been thinking all members have permissions to do that (close dependabot PRs). Can you double check it?

[henrybear327]

Sadly, no, otherwise I would have done it directly in the past few weeks :D