raft: add raft test suite #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| drop(from, to uint64, rate float64) | ||
| // delay message for (0, d] randomly at given rate (1.0 delay all messages) | ||
| // do we need rate here? | ||
| delay(from, to uint64, d time.Duration, rate float64) |
There was a problem hiding this comment.
Maybe a duplicate(from, to uint64, d time.Duration, rate float64) option as well? (messages are sent a second time after (0, d] seconds)
There was a problem hiding this comment.
sure, we could. but actually i think it is the not the network, but the raft node that generates the duplicate messages. When do you think a network layer would duplicate a message in reality?
There was a problem hiding this comment.
That's true, I guess all the duplicate-message scenarios I can come up with are actually the application retrying.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start a basic raft test suite.
the goal of this pr is to set up the desired network interface and the functionality of node.
a node should be able to restart, pause.
a network should be able to delay, drop message.