etcdserver: better v3 api error handling #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return &pb.ResponseUnion{ResponseRange: applyRange(kv, union.RequestRange)} | ||
| resp, err := applyRange(kv, union.RequestRange) | ||
| if err != nil { | ||
| panic("unexpected error during txn") |
There was a problem hiding this comment.
why does it panic here? It may be ErrCompacted, right?
There was a problem hiding this comment.
we should check potential errors before executing the transaction. we cannot abort executed commands.
see line 120 for more details.
There was a problem hiding this comment.
I see. So the point is that as long as txn starts, it should be successful.
|
LGTM |
xiang90
added a commit
that referenced
this pull request
Sep 16, 2015
etcdserver: better v3 api error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to handle error