Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support watcher cancellation inside watchStream #4120

Merged
merged 1 commit into from
Jan 3, 2016
Merged

*: support watcher cancellation inside watchStream #4120

merged 1 commit into from
Jan 3, 2016

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Jan 3, 2016

@gyuho
Copy link
Contributor

gyuho commented Jan 3, 2016

LGTM. I tried this code and works great.

./etcdctlv3 --endpoint=localhost:1178 watch
watch a
watcher created: id 00000000
PUT: a bbbbbb
PUT: a bbcccc
cancel 00000000
watcher canceled: id 00000000
watch a
watcher created: id 00000001
PUT: a bbccccd
PUT: a bbccccdsadasd
PUT: a bbccccdsadasdasdsadsa

xiang90 added a commit that referenced this pull request Jan 3, 2016
@xiang90
Merge pull request #4120 from xiang90/ctrl_w
c832d7f 
*: support watcher cancellation inside watchStream
@xiang90 xiang90 merged commit c832d7f into etcd-io:master Jan 3, 2016
@xiang90 xiang90 deleted the ctrl_w branch January 3, 2016 17:14
@yichengq yichengq mentioned this pull request Jan 4, 2016
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiang90 @gyuho