*: WatchResponse for multiple Events with WatchID #4122
Conversation
gyuho
changed the title
|
Please take a look. Thanks! |
gyuho
changed the title
| int64 watchID = 3; | ||
| } | ||
|
|
||
| message WatchResponse { |
There was a problem hiding this comment.
we do not need this proto message. we should use the WatchResponse proto defined in rpc.proto in etcdserverpb pkg.
There was a problem hiding this comment.
move this back to watcher.go. We only need proto when we want to send it over wire. This type is just an internal message between two pkgs inside on process.
There was a problem hiding this comment.
Makes sense. I will just import etcdserverpb.WatchResponse type.
There was a problem hiding this comment.
No. Do not import that type. Just create WatchResponse in watcher.go as what I have did in my original commit. Do not use proto type unless you are going to marshal the exact struct.
|
@xiang90 @heyitsanthony Please take a look again. I removed all unnecessary changes |
|
Let squash all commits into one. |
|
LGTM after squashing. |
|
OK I will squash then into one. Thanks! Sincerely,
|
storage/storagepb: remove watchID from Event storage: add WatchResponse to watcher.go to wrap events, watchID storage: watchableStore to use WatchResponse storage: kv_test with WatchResponse etcdserver/api/v3rpc: watch to receive storage.WatchResponse type
gyuho
changed the title
|
@xiang90 Just squashed them all. Will merge after CI passes. Thanks, |
*: WatchResponse for multiple Events with WatchID
Reference: xiang90@ce07ae9