clientv3/integration: test lease keepalive #4369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
8 tasks
| kresp := <-rc | ||
| if kresp.ID != resp.ID { | ||
| t.Errorf("ID = %x, want %x", kresp.ID, resp.ID) | ||
| } |
There was a problem hiding this comment.
test the channel closes on Close()?
|
can this test the ctx cancel logic too? |
|
@heyitsanthony I wanted. However the keepAlive ctx is unimplemented right now. I plan to implement and then test it as a whole. |
|
ok, fair enough |
|
@heyitsanthony fixed a bunch of small issues. PTAL. |
| @@ -182,6 +187,10 @@ func (c *Client) retryConnection(oldConn *grpc.ClientConn, err error) (*grpc.Cli | |||
| // connection is established. | |||
| func dialEndpointList(c *Client) (*grpc.ClientConn, error) { | |||
| var err error | |||
| if len(c.Endpoints()) == 0 { | |||
There was a problem hiding this comment.
would it be better to put this in New instead of checking in the retrydialer every redial?
|
lgtm after fixing nits |
|
close in favor of #4382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @heyitsanthony @gyuho