clientv3/integration: add TestKVDelete* #4372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
force-pushed
the
kv_delete
branch
2 times, most recently
from
fcfc6f8
to
4596b97
Compare
8 tasks
| if dresp.Header.Revision != tt.delRev { | ||
| t.Fatalf("#%d: dresp.Header.Revision got %d, want %d", i, dresp.Header.Revision, tt.delRev) | ||
| } | ||
| grespKey, err := kv.Get(tt.key, 0) |
There was a problem hiding this comment.
we do not have to test get here. we should assume the server side do the current thing. but it does not hurt either.
There was a problem hiding this comment.
probably we should just do a range and expect nothing in the range.
|
@xiang90 Just addressed. PTAL. Thanks, |
|
LGTM |
|
Thanks! |
gyuho
added a commit
that referenced
this pull request
Feb 2, 2016
clientv3/integration: add TestKVDelete*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @xiang90 @heyitsanthony
Thanks!