clientv3/integration: add TestKVCompact #4413
Conversation
|
lgtm-- should we also test that compact closes a watcher, though? |
|
Sure. Will add it too. Thanks. On Thu, Feb 4, 2016, 08:30 Anthony Romano notifications@github.com wrote:
|
hmm... This is testing the client actually. So we should not test the server behavior of closing the watchers here. Right? |
| t.Fatalf("couldn't compact kv space (%v)", err) | ||
| } | ||
| err := kv.Compact(2) | ||
| if err == nil || !strings.Contains(err.Error(), storage.ErrCompacted.Error()) { |
There was a problem hiding this comment.
can you please add these types to v3rpc/errors.go and add the error handling to togRPCError func?
There was a problem hiding this comment.
then we can do err != v3rpc.ErrCompacted.
There was a problem hiding this comment.
Yeah. Will add. Thanks.
On Thu, Feb 4, 2016, 09:17 Xiang Li notifications@github.com wrote:
In clientv3/integration/kv_test.go
#4413 (comment):
- clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3})
- defer clus.Terminate(t)
- kv := clientv3.NewKV(clus.RandClient())
- for i := 0; i < 3; i++ {
if _, err := kv.Put("foo", "", lease.NoLease); err != nil {t.Fatalf("couldn't put 'foo' (%v)", err)}- }
- if err := kv.Compact(2); err != nil {
t.Fatalf("couldn't compact kv space (%v)", err)- }
- err := kv.Compact(2)
- if err == nil || !strings.Contains(err.Error(), storage.ErrCompacted.Error()) {
then we can do err != v3rpc.ErrCompacted.
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/etcd/pull/4413/files#r51904815.Sincerely,
Gyu-Ho Lee
|
It would test the logic in the client responsible for closing an outdated watcher channel on a compact. |
|
@heyitsanthony OK. You are right. |
PTAL. Thanks. |
| wr, ok := <-wchan | ||
| empty := reflect.DeepEqual(emptyResp, wr) | ||
| if !empty { | ||
| t.Fatalf("expected empty response from closed channel, got %+v", wr) |
There was a problem hiding this comment.
we usually print out what we got first, then print out what we want.
|
@xiang90 Just addressed. PTAL. Thanks. |
| wchan := wc.Watch(context.TODO(), "foo", 3) | ||
|
|
||
| wr, ok := <-wchan | ||
| isEmpty := reflect.DeepEqual(clientv3.WatchResponse{Header: pb.ResponseHeader{}, Events: nil}, wr) |
There was a problem hiding this comment.
remove the empty checking since this ensures by go runtime that when a chan is closed it returns empty response.
|
LGTM |
|
Just fixed. Will merge after green lights. Thanks! |
|
Semaphore is not responding... I ran integration test on Google cloud machine and confirmed that all tests pass. |
clientv3/integration: add TestKVCompact
Finishing #4338.