Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3: don't halt lease client if there is a lease error #7866

Closed
wants to merge 8 commits into from

Conversation

heyitsanthony
Copy link
Contributor

From reverted API change. Figure out what to do with this when API breakage is OK.

@heyitsanthony heyitsanthony added this to the v4.0.0 milestone May 3, 2017
@codecov-io
Copy link

codecov-io commented May 3, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@8990126). Click here to learn what that means.
The diff coverage is 77.58%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7866   +/-   ##
=========================================
  Coverage          ?   75.61%           
=========================================
  Files             ?      332           
  Lines             ?    26192           
  Branches          ?        0           
=========================================
  Hits              ?    19806           
  Misses            ?     4961           
  Partials          ?     1425
Impacted Files Coverage Δ
etcdctl/ctlv3/command/lease_command.go 67.07% <0%> (ø)
proxy/grpcproxy/lease.go 89.42% <100%> (ø)
clientv3/concurrency/session.go 95.12% <100%> (ø)
integration/cluster_proxy.go 100% <100%> (ø)
clientv3/lease.go 93.6% <81.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8990126...d59f6c1. Read the comment docs.

@stale
Copy link

stale bot commented Apr 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2020
@stale stale bot closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants