wal: fall back to closing wal if locked dir rename fails #8286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8286 +/- ##
=========================================
Coverage ? 76.26%
=========================================
Files ? 345
Lines ? 27074
Branches ? 0
=========================================
Hits ? 20647
Misses ? 4939
Partials ? 1488
Continue to review full report at Codecov.
|
heyitsanthony
force-pushed
the
wal-check-locks
branch
from
0871113
to
032426d
Compare
heyitsanthony
force-pushed
the
wal-check-locks
branch
from
032426d
to
fe1ddab
Compare
|
turns out the error is *os.LinkError not os.ErrPermission; works on windows |
Detecting windows at compile time isn't enough since etcd might be on linux but the fs is backed by windows. Fixes: etcd-io#8178 Fixes: etcd-io#6984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detecting windows at compile time isn't enough since etcd might be
on linux but the fs is backed by windows.
Fixes: #8178
Fixes: #6984
WIP until I can confirm the fix on windows.
Also supersedes #7915