concurrency: retry snapshot serializable stm if writes since first header rev #8439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
reviewed
Aug 22, 2017
integration/v3_stm_test.go
Outdated
| defer clus.Terminate(t) | ||
|
|
||
| cli := clus.Client(0) | ||
| // key with different revision from keys updated |
There was a problem hiding this comment.
What does it mean key with different revision from keys updated?
There was a problem hiding this comment.
the create/mod rev is always earlier than the keys set via stm
heyitsanthony
force-pushed
the
stm-serialized-snapshot
branch
2 times, most recently
from
b962863
to
b206afc
Compare
…ader rev Was checking the rset key mod rev, which does not work.
Worked by coincidence; the txn would always retry and there was a 1/10 chance it would pass by selecting the same to/from keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was checking the rset key mod rev, which does not work.