Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft: fix deadlock during PreVote migration process #8525

Merged
merged 1 commit into from
Jan 27, 2018
Merged

raft: fix deadlock during PreVote migration process #8525

merged 1 commit into from
Jan 27, 2018

Conversation

lishuai87
Copy link
Contributor

Fixes #8501

@lishuai87 lishuai87 force-pushed the pre-vote-compatible branch 2 times, most recently from 8c1ee07 to 6ffb7aa Compare September 8, 2017 10:13
@lishuai87 lishuai87 mentioned this pull request Sep 8, 2017
Closed
@xiang90
Copy link
Contributor

xiang90 commented Sep 8, 2017

/cc @irfansharif

@irfansharif irfansharif mentioned this pull request Sep 8, 2017
Closed
@irfansharif
Copy link
Contributor

Please see #8501 (comment).

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@80aa810). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #8525   +/-   ##
========================================
  Coverage          ?   65.9%           
========================================
  Files             ?     360           
  Lines             ?   29527           
  Branches          ?       0           
========================================
  Hits              ?   19459           
  Misses            ?    8399           
  Partials          ?    1669
Impacted Files Coverage Δ
raft/raft.go 91.87% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80aa810...8597361. Read the comment docs.

@bdarnell bdarnell mentioned this pull request Jan 23, 2018
Closed
bdarnell
bdarnell approved these changes Jan 26, 2018
View reviewed changes
Copy link
Contributor

@bdarnell bdarnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change should be merged.

@xiang90
Copy link
Contributor

xiang90 commented Jan 27, 2018

@bdarnell

thanks for the review. merging.

@xiang90 xiang90 merged commit d54f281 into etcd-io:master Jan 27, 2018
@siddontang siddontang mentioned this pull request Jan 27, 2018
Closed
@lishuai87 lishuai87 deleted the pre-vote-compatible branch January 27, 2018 11:24
bdarnell added a commit to bdarnell/cockroach that referenced this pull request Jan 28, 2018
@bdarnell
build: Update etcd
a8c854d 
This picks up some changes to prevote (etcd-io/etcd#8525 and
etcd-io/etcd#9204), as well as a new ErrProposalDropped that we're not
yet using.

Release note: None
This was referenced Jan 28, 2018
Merged
Closed
@lishuai87 lishuai87 mentioned this pull request Dec 28, 2018
Merged
@absolute8511 absolute8511 mentioned this pull request Feb 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdarnell bdarnell bdarnell approved these changes

Assignees
No one assigned
Labels
area/raft
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lishuai87 @xiang90 @irfansharif @codecov-io @bdarnell