Do not recover db snapshot if index is 0 #9481
Conversation
... as that would indicate that the backend is newly initialized store rather than an outdated snapshot. Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
|
@gyuho I've confirmed that this fixes the issue I was seeing but I'm not 100% certain that it's safe. |
|
This code block suggests to me that it may be safe (it logs a warn message instead of returning an error). There's also that |
|
This is unsafe. v3 should still panic on accidental db file deletion. I will add an optional flag to allow boot from empty db file, in case of upgrades from v2. |
We still support upgrades from pre-3.0. We might panic in that TODO in v4 (where v2 support is completely dropped). |
That code block only applies when |
The |
Then, that file should have been created from v3.0 migrate. Since we only support v3.2 and v3.3, we will provide a way to override that in v3.2. It would be like:
|
|
@gyuho if that is the suggested upgrade process then I wonder if it would just be okay to upgrade directly from v2.3 to v3.2 (with the understanding that this would not be a zero-downtime upgrade) using the Also, what would be the recommended next step? I would guess that you would want to start the server using |
|
@jlhawn Yeah... just upgrade directly to v3.2 should be easier (as long as there will be no v3 data). Sorry for confusing steps. I will make sure to document this process. |
I will document the steps in #9484. |
Thanks! I'll ask more questions there if I have any. |
... as that would indicate that the backend is a newly initialized
store rather than an outdated snapshot.
Fixes #9480
cc @gyuho