Add handling for "etcdserver: revision of auth store is old" #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darvay
force-pushed
the
auth_store_issue
branch
2 times, most recently
from
d76e26d
to
d92c88c
Compare
|
is there any way to add a test ? |
|
Thanks for the review @lburgazzoli , I wasn't sure how to trigger this error condition via unit tests, I see WatchUnitTest.java does a check for that error message but didn't see a test for Errors.INVALID_AUTH_TOKEN_ERROR_MESSAGE . We have been relying on an integration test running Etcd 3.5.2 with multiple etcdctl role add/updates to try to trigger the error condition. |
|
Yeah we don have test for all the cases but if there is a way to test it, I would really appreciated given my very limited time to support the project |
darvay
force-pushed
the
auth_store_issue
branch
from
d92c88c
to
f974da7
Compare
|
@lburgazzoli let me know if this test will work |
…perienced by customers when Role changes are made to the ETCD Cluster. We are seeing a use case when ETCD Role grants are updated we are getting an error "etcdserver: revision of auth store is old" on all JETCD clients right after the grant is applied. The only fix now is for the client to restart and reconnect. ETCD Cluster config: ETCD_AUTH_TOKEN: jwt,pub-key=/auth-token/authToken.pub,priv-key=/auth-token/authToken.key,sign-method=RS256,ttl=8h Signed-off-by: darvay <darvay@apple.com>
darvay
force-pushed
the
auth_store_issue
branch
from
f974da7
to
744a8d9
Compare
|
@lburgazzoli hope all is well, did you have a chance to review the added test? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error experienced by customers when Role changes are made to the ETCD Cluster.
We are seeing a use case when ETCD Role grants are updated we are getting an error "etcdserver: revision of auth store is old" on all JETCD clients right after the grant is applied. The only fix now is for the client to restart and reconnect.
ETCD Cluster config:
ETCD_AUTH_TOKEN: jwt,pub-key=/auth-token/authToken.pub,priv-key=/auth-token/authToken.key,sign-method=RS256,ttl=8h