Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compile version to java11. #1300

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Jan 13, 2024

Fixes #1218,#1181

This PR Update compile version to java11 from java8.

vertx-grpc need the javax.annotation, so we need add javax.annotation for it

...
jetcd/jetcd-grpc/build/generated/source/proto/main/grpc/io/etcd/jetcd/api/LeaseGrpc.java:7: error: package javax.annotation does not exist
@javax.annotation.Generated(
                 ^
...

I will suggess create a branch like release-0.7 for java8 before merge this PR ,Just in case people want to do something on jetcd for java8.

/hold

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@lburgazzoli lburgazzoli merged commit 4759815 into etcd-io:main Jan 16, 2024
9 checks passed
@liangyuanpeng liangyuanpeng deleted the compile_java11 branch January 16, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Drop java 8
3 participants