testdata: add a lagging commit test #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pav-kv
force-pushed
the
lagging-commit-test
branch
from
b030d6d
to
912b496
Compare
3 tasks
pav-kv
force-pushed
the
lagging-commit-test
branch
from
912b496
to
9ef2cb9
Compare
|
@nvanbenschoten @ahrtr PTAL. This is a regression test for potential future fixes for #138. |
pav-kv
force-pushed
the
lagging-commit-test
branch
from
9ef2cb9
to
53d373c
Compare
This commit adds a test demonstrating the effect of delayed commit on a follower node after a network hiccup between the leader and this follower. In the described scenario, after the moment of committing an entry on the leader, it takes HeartbeatInterval + 3/2 * RTT until the follower learns this entry is committed. This is suboptimal, and could take HeartbeatInverval + 1/2 * RTT if the leader didn't cut the commit index at Progress.Match before sending it to the follower. Signed-off-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
pav-kv
force-pushed
the
lagging-commit-test
branch
from
53d373c
to
8a26275
Compare
Why do we care? Follower reads? |
Yes, and also the general "convergence" of the system (resulting in fewer messages etc). For other kinds of reads, like quorum reads, this also seems relevant. |
erikgrinaker
approved these changes
Jan 31, 2024
|
@ahrtr Good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a test demonstrating the effect of delayed commit on a follower node after a network hiccup between the leader and this follower.
In the described scenario, after the moment of committing an entry on the leader, it takes
HeartbeatInterval + 3/2 * RTTuntil the follower learns this entry is committed.This is suboptimal, and could take
HeartbeatInverval + 1/2 * RTTif the leader didn't cut the commit index atProgress.Matchbefore sending it to the follower.Informs #138