Docsy theme #244
Merged
Docsy theme #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass at integrating etcd into a shell docsy themed hugo site. * Moving content/docs to content/en/docs * Updating netlify.toml, config.toml, and Docker config * first pass at versions dropdown menu for docs pages * Updating hugo version to 0.81.0 (ext) in Dockerfile and netlify.toml * updating preview-build command * updating package.json * requiring lts node version * Adding content to en/_index.html, updating config.toml, updating navbar-version-selector to ensure it works with multiple languages. * updating package.json & removing package-lock.json * changing from npm ci to npm install as we removed the package-lock.json file Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
* Drop About from docsy MVP, and make link checker happy * Homepage: remove data-proofer-ignore
(For sake of consistency)
nate-double-u
added
the
docsy
Closed
34 tasks
|
Looks amazing thank you @nate-double-u and team. LGTM |
spzala
reviewed
Apr 22, 2021
There was a problem hiding this comment.
lgtm, great look and feel as we discussed! Thanks @nate-double-u @chalin
|
Wonderful, thanks for the feedback @hexfusion and @spzala! |
|
@nate-double-u - can you merge this today (either before or after #203), given that this PR has been open for a week? While I might not get to doing etcd work today, if you can merge before the EOD, I'll be able to make some progress at least as of tomorrow morning (ET). |
nate-double-u
approved these changes
Apr 26, 2021
|
Followup changes will be tracked via #247 |
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion to the Docsy theme is complete.
You'll find the preview next and screenshots below:
Preview: https://docsy--etcd.netlify.app
@spzala @ptabor @jberkus - PTAL and let @nate-double-u and I know if you find that this is good enough to use as a base for continued development.
If there are no objections, we'd like to merge this by Thursday (04/22) at the latest so that we can then move ahead with the implementation of the new IA, and any further changes that you'd like made to the site.
Screenshots
Homepage:
Site page: