Updated instructions for acessing (reading and writing) an etcd KV pair #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhbnz
reviewed
Mar 22, 2024
There was a problem hiding this comment.
Hey @dwelsch-esi - Thanks for raising this update. To enable us to merge this can you please ensure your commit is signed so our developer certificate of origin check passes.
For example:
git rebase HEAD~2 --signoff
git push --forceAdditionally - I would suggest we update the v3.5 version of these tutorials to match.
dwelsch-esi
force-pushed
the
doc-improvements
branch
from
7503eea
to
6fa6d97
Compare
|
DCO corrected. |
Hi @dwelsch-esi - Reviewing the diff it looks like there are now unintended changes showing? Additionally please squash commits to ensure only one commit is present. |
- Break `how-to-access-etcd` into two files: - `writing-to-etcd` - `reading-from-etcd` - Rename pages from "How to access ..." to "Writing ..." and "Reading ..." - Added Prerequisite section - Removed animated GIF - Revised procedure to explain keywords Create reading-from-etcd.md updating v3.5 with same v3.6 content as above. Signed-off-by: Nate W <natew@cncf.io>
nate-double-u
force-pushed
the
doc-improvements
branch
from
6fa6d97
to
70339db
Compare
|
@jmhbnz I've helped Dave to rebase this and update for both v3.5 and v3.6. |
ivanvc
pushed a commit
to ivanvc/etcd-website
that referenced
this pull request
May 13, 2024
- Break `how-to-access-etcd` into two files: - `writing-to-etcd` - `reading-from-etcd` - Rename pages from "How to access ..." to "Writing ..." and "Reading ..." - Added Prerequisite section - Removed animated GIF - Revised procedure to explain keywords Create reading-from-etcd.md updating v3.5 with same v3.6 content as above. Signed-off-by: Nate W <natew@cncf.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #790.