forked from etcd-io/etcd
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standby test and fix some bugs #67
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client have to read whole response bodies if they want the advantage of reusing TCP connections. https://code.google.com/p/go/source/detail?r=d4e1ec84876c0f5611ab86a03826da14b866efb2&name=release-branch.go1.1&path=/src/pkg/net/http/transport.go
To be more readable and get rid of false error message.
WIP etcd: snap and wal init
server: don't print out errors that cannot be resolved
server: remove panic or fatal in participant.run
*: rename etcd to etcdserver
etcd: add consistent get
etcdserver: rename someMachineMessage->machineMessage
wal: move record method to record.go
conf: remove GraphiteHost flag
etcdserver: use snapshotCount flag
|
||
lead, _ := cl.Leader() | ||
config := conf.NewClusterConfig() | ||
config.ActiveSize = -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a comment for this? i have no idea why we need to change activeSize to -1.
yichengq
force-pushed
the
y-standby-test
branch
from
August 25, 2014 17:31
3289663
to
58ee6f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.