-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: compiler/client rewrite #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Too much escaping - Self closing elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Future of Etcher.
Until this point Etcher's parsing/rendering process has happened fully in the Client.
The client script was passed a string of XTML and registered a component.
This means that the Client bundle size was exceeding 20kb and executed some heavy Regular Expressions.
This Pull Request changes that behaviour completely. The new compiler uses
html-parse-string
under the hood to create an AST and output an explicit series of internal function calls.So, what does this mean?
Before these changes, etcher tried to implement fine-grained reactivity by generating a CSS selector to target an element with an interpolated expression. The new system walks down the DOM tree to accurately find the correct node.
Our new reactive system uses pseudo-signals to create a more reliable and maintainable feature.
Syntax Changes.
This update will also bring some major syntax changes aside from the obvious removal of the
{@state count = 0}
syntax.Loop
The loop directive is now written in an xml format. It can also support 2 different attribute formats.
For
Like
<Loop>
, the for directive is also now written in an xml format.If
I think you know the drill by now...
In summation, this pull request is a momentous occasion for Etcher. It re-defines how our Client script works and sows the seeds for future updates to flourish.