Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break from read loop when underlying sockets is drained #15

Merged
merged 1 commit into from
Aug 4, 2016

Conversation

MartinNowak
Copy link
Contributor

This should fix a bug where an application of mine gets regularly stuck in a busy loop, b/c a requested remote server ends the connection early.

This should fix a bug where an application of mine gets regularly stuck in a busy loop, b/c a requested remote server ends the connection early.
@etcimon etcimon merged commit eb11e31 into etcimon:master Aug 4, 2016
@etcimon
Copy link
Owner

etcimon commented Aug 4, 2016

Thanks

@MartinNowak MartinNowak deleted the patch-1 branch August 5, 2016 16:24
MartinNowak added a commit to MartinNowak/alertd that referenced this pull request Sep 30, 2016
MartinNowak added a commit to MartinNowak/alertd that referenced this pull request Sep 30, 2016
- see etcimon/botan#15
- also remove optional unused dependencies (requires manual editing of
  botan&vibe-d's dub.json)
etcimon pushed a commit that referenced this pull request Oct 1, 2016
break from read loop when underlying sockets is drained
@MartinNowak
Copy link
Contributor Author

Empirically approved to solve the problem after several weeks w/o further busy locks.

@etcimon
Copy link
Owner

etcimon commented Oct 27, 2016

Good, I also had an issue with a busy loop here: https://issues.dlang.org/show_bug.cgi?id=16641
and when returning 0 from read here: etcimon/vibe.0@2e78a93#diff-e8a2fb8b250e93ebede4ffc01c2c0741R342
and here: 7663bea#diff-fecfb5991c6f6086c030d831fb5db1b8R119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants