Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Ethereum protocol version to be set user configurable #244

Merged
merged 5 commits into from
Nov 30, 2020

Conversation

ziogaschr
Copy link
Member

Adds a new cli arg to geth for configuring the supported Ethereum protocol versions.
The new cli arg is --ethprotocols=[value] which accepts comma separated string of the supported protocol versions [65|64|63].

This PR resolves #109.

cmd/utils/flags.go Outdated Show resolved Hide resolved
cmd/utils/flags.go Outdated Show resolved Hide resolved
cmd/utils/flags.go Outdated Show resolved Hide resolved
cmd/utils/flags.go Outdated Show resolved Hide resolved
cmd/utils/flags.go Outdated Show resolved Hide resolved
cmd/utils/flags.go Outdated Show resolved Hide resolved
cmd/utils/flags.go Outdated Show resolved Hide resolved
cmd/utils/flags.go Outdated Show resolved Hide resolved
Copy link
Member

@meowsbits meowsbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meowsbits meowsbits merged commit b24f489 into master Nov 30, 2020
@meowsbits meowsbits deleted the feat/eth-protocol-cli branch November 30, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create an --eth-protocol=[65|64|63] flag?
2 participants