Fix/faucet discovery dns defaults #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No DNS discovery defaults were getting set because you can't test on pointer equivalence , which was being done on the genesis blocks. Instead, compare on Hash equivalence (and handle disambiguation for ETC vs. ETH using chain ID (61 vs. 1)). Adds a couple log lines at start up for more helpful debug logging. Date: 2020-12-08 06:53:29-06:00 Signed-off-by: meows <b5c6@protonmail.com>
|
Rel #240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No DNS discovery defaults were getting set
because you can't test on pointer equivalence
, which was being done on the genesis blocks.
Instead, compare on Hash equivalence
(and handle disambiguation for ETC vs. ETH
using chain ID (61 vs. 1)).
Adds a couple log lines at start up for
more helpful debug logging.
Date: 2020-12-08 06:53:29-06:00
Signed-off-by: meows b5c6@protonmail.com