Add native callTracer and refactor based on new go-ethereum paradigms #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs/js/internal/tracers: rename tracer; fix precompiled check to happen on CaptureExit
…s legacy (is slower)
…reationMethod` from tests
…emove `creationMethod` from tests" This reverts commit 0385ae4.
…st all available Parity tracers
…or native tracer
…xt to `callTracerParity` native tracer
…s/native: on parity tracer (Delegate|Static)call uses the value from parent, if zero
… struct definitions with tests
…ide` test for call_tracer_parity
…ative tracer, with OE
… native Parity tracer
…a/state_diff: use stateOverrides for stateDiff tracer (draft)
…gatecall (to be cross-checked)
…a/state_diff: fix/change stateDiff tracer tests to use stateOverrides
|
Is this still a WIP? Any in particular you'd like feedback on? |
|
No it's not, I just want to squash some commits. I suggest we merge this branch on Monday and continue with stateDiff on a new branch. |
…t stateDiff test runner to use non Legacy tracer
…ce_call go-ethereum instead added stateOverrides support
…a/call_tracer_parity,eth/tracers/js/internal/tracers,eth/tracers/native: eth/tracers/internal/tracetest,eth/tracers/internal/tracetest/testdata/call_tracer_parity,eth/tracers/js/internal/tracers,eth/tracers/native: (omit)empty Parity call tracer fields based on OE
…racers/internal/tracetest,eth/tracers/js/internal/tracers: remove callTracerParityJs as we a same native tracer and it will add tech debt for later in order to remove it
ziogaschr
force-pushed
the
merge/foundation-release/1.10.17-tracer
branch
from
e71019b
to
4bc7f95
Compare
ziogaschr
changed the title
meowsbits
reviewed
Apr 18, 2022
eth/tracers/internal/tracetest/testdata/call_tracer_parity/deep_calls.json
Show resolved
Hide resolved
Renames method to make it clear that the method will modify the pointer argument. Date: 2022-04-18 06:07:11-07:00 Signed-off-by: meows <b5c6@protonmail.com>
meowsbits
reviewed
Apr 18, 2022
meowsbits
approved these changes
Apr 18, 2022
|
LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR achieves the following:
[x] Refactor of parity like tracer added at core-geth, so as it follows the go-ethereum paradigms.
[x] Add new native
callParityTracerthat is much faster as it runs in Go.[x] Add more tests for tracers.
[x] Update the compatibility layer with OE based on their latest changes, and running a full comparison test based on this OE branch which used OE v3.3.4.
--
stateDifftracer will be simplified and be converted in a native tracer in a next PR.