feat: common code formatting rules with rustfmt #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mersinvald
force-pushed
the
feat/rustfmt
branch
2 times, most recently
from
3e86815
to
d483e3a
Compare
added 3 commits
March 24, 2019 15:04
- annotate Patch trait implementations as to-be-skipped during formatting
- enable cargo caching for travis builds - install rustfmt for stable
…tfmt` in this repo
mersinvald
force-pushed
the
feat/rustfmt
branch
from
d483e3a
to
22fa140
Compare
mersinvald
changed the title
r8d8
approved these changes
Mar 25, 2019
This was referenced Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies global formatting rules (described in
rustfmt.toml) to the codebase.WIth the CI stage checking the formatting for correctness, this is the first step to enforsing the common formatting style in the repo.
Closes #30
This is not a breaking change, though it would require applying the formatting for those branches created from unformatted master base before the merge.
In my opinion the easiest way to go with these branches is to copy the
rustfmt.tomlfrom master, runcargo fmtand then make amaster->branchmerge instead of the rebase to minimize git conflicts.