Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: All arguments are expected to be objects vs method params or objects #78

Open
zcstarr opened this issue Oct 18, 2019 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@zcstarr
Copy link

zcstarr commented Oct 18, 2019

Currently Jade Signer doesn't support the expressive ness of the open-rpc document. All the Json-RPC API interfaces don't respect individual params to be serialized ( as far as I can tell).

Motivation: We want to provide a nice logical interface for devs to interact with jade signer, this means that for request like export_Account. The format should not be

export_Account( {address: "0xBEAD.."}, {chainID: 61}) but preferably
export_Account("0xBEAD",61); Where the client type annotations inform the developer what is what. Additionally we should still support the former interface where it makes sense

Acceptance Criteria:
Jade Signer accepts single variable arguments to rpc request, meaning it supports named params and positional params.

@zcstarr zcstarr added the bug Something isn't working label Oct 18, 2019
@zcstarr zcstarr self-assigned this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant