Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application arguments are not listed in Application Arguments dialog #266

Closed
10110111 opened this issue Oct 10, 2015 · 3 comments
Closed

Comments

@10110111
Copy link
Contributor

If you run edb like this

edb --run `which true` --parm

, then the debuggee does get its --parm argument, but clicking Options_→_Application Arguments gives a dialog with empty list.

@eteran
Copy link
Owner

eteran commented Oct 10, 2015

So this is trivial to implement (already have it in my local code). But here's the question:

so we run:

edb --run `which true` --parm

This puts --parm into the dialog. OK, good. When true finishes, should it still be in there? There are a few possibilities, with varying levels of complexity:

  1. we just leave it in there, it's up to the user to sort out the args if they re-run the app, or run a different one
  2. we clear it out, the arguments only applied to that particular run
  3. we leave it in there, but warn if they run a different executable than the original one
  4. we make the arguments system much more complex and robust. we make it so arguments aren't a flat list, but a set of lists where we remember the set of arguments each unique executable was run with.

#4 sounds the most useful, but it gets complex, especially in the context of a user running an app, then setting the arguments for the next app, then opens the next app. Should the arguments only be associated with the second? both?

What do Ollydbg and/or x64dbg do?

eteran added a commit that referenced this issue Oct 11, 2015
also, commiting a fix for issue #266. It's not "perfect", but it is consistant with
how we act when we attach to processes, so it's fine for now.
@eteran eteran closed this as completed Oct 11, 2015
@10110111
Copy link
Contributor Author

In OllyDbg the arguments seem to be associated with the particular run of the application, and also saved in the list of recently debugged applications. If the user opens a New App window (e.g. pressing F3), the arguments list is empty (this feature is not present in EDB, it can't set parameters at this stage), but if Ctrl+F2 is pressed (or any other recent app is chosen) even when no app is being debugged, the ones from the recently debugged apps list are used.

@eteran
Copy link
Owner

eteran commented Oct 11, 2015

Right, I plan to improve how arguments are handled and saved, especially related to the recent file list. Gonna try to think about the best way to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants