Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPlugin::save_state is never called #326

Closed
10110111 opened this issue Jan 9, 2016 · 3 comments
Closed

IPlugin::save_state is never called #326

10110111 opened this issue Jan 9, 2016 · 3 comments

Comments

@10110111
Copy link
Contributor

10110111 commented Jan 9, 2016

I've just to put my state saving code there to discover that it's never called. Grepping the code gave zero mentions it.

@eteran
Copy link
Owner

eteran commented Jan 10, 2016

probably about time that I implement session files :-) Related bugs:

#36, #2, #3

@eteran
Copy link
Owner

eteran commented Jan 16, 2016

@10110111, just a heads up that I am considering changing the plugin state API. At the moment, it is based on a QByteArray, but I think it may be better to use QVariantMap. This will make it simpler to store the results in human readable formats if desired.

Any objections?

@10110111
Copy link
Contributor Author

This is a good thing I think. And I'm currently not using state API since it doesn't work, so it shouldn't conflict if you change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants