Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOT API 7.3 #2264

Merged
merged 16 commits into from
May 11, 2024
Merged

BOT API 7.3 #2264

merged 16 commits into from
May 11, 2024

Conversation

Badiboy
Copy link
Collaborator

@Badiboy Badiboy commented May 10, 2024

Bot API 7.3

  • Added support for InlineKeyboardMarkup with url, login_url, and callback_game buttons for messages sent on behalf of a business account.
  • Added the field via_join_request to the class ChatMemberUpdated.
  • Added support for live locations that can be edited indefinitely, allowing 0x7FFFFFFF to be used as live_period.
  • Added the parameter live_period to the method editMessageLiveLocation.
  • Added the field question_entities to the class Poll.
  • Added the field text_entities to the class PollOption.
  • Added the parameters question_parse_mode and question_entities to the method sendPoll.
  • Added the class InputPollOption and changed the type of the parameter options in the method sendPoll to Array of InputPollOption.
  • Added the classes ChatBackground, BackgroundType, BackgroundFill and the field chat_background_set of type ChatBackground to the class Message, describing service messages about background changes.
  • Split out the class ChatFullInfo from the class Chat and changed the return type of the method getChat to ChatFullInfo.
  • Added the field max_reaction_count to the class ChatFullInfo.
  • Documented that .MP3 and .M4A files can be used as voice messages.

Badiboy added 16 commits May 10, 2024 11:39
… options in the method sendPoll to Array of InputPollOption.
…the field chat_background_set of type ChatBackground to the class Message, describing service messages about background changes.
…return type of the method getChat to ChatFullInfo. Added the field max_reaction_count to the class ChatFullInfo.
@Badiboy
Copy link
Collaborator Author

Badiboy commented May 11, 2024

@coder2020official I'm done.

Regarding this:

Split out the class ChatFullInfo from the class Chat and changed the return type of the method getChat to ChatFullInfo.

Here: 3532812 I currently left "Chat" as a full copy of "ChatFullInfo". It will left compatibility without making tenths of stubs with warnings. Later we can do it if anyone will have time for that.

@coder2020official
Copy link
Collaborator

Got your message.
I will try reviewing tonight

Copy link
Collaborator

@coder2020official coder2020official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, it looks good to me...

@@ -6972,6 +6975,7 @@ def __init__(
self.correct_option_id: int = correct_option_id
self.explanation: str = explanation
self.explanation_entities: List[MessageEntity] = explanation_entities
self.question_entities: List[MessageEntity] = question_entities
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some function to convert these entities into html i think; can you do that now or do we postpone it for later?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it in the same way as other entities in this class. Thus if we want to have some function (I did not get which one) - we can do it later for all such entities.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like html_caption or html_text

telebot/apihelper.py Outdated Show resolved Hide resolved
@Badiboy Badiboy merged commit d9c4abe into eternnoir:master May 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants