Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependecies (Again...) #126

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Update dependecies (Again...) #126

merged 1 commit into from
Mar 23, 2022

Conversation

victor-rds
Copy link
Contributor

This one is to fix my own PR #125, the requirement files contained the following sentence:

"To update, run: pip-compile --output-file=requirements.txt requirements.in/base.txt"

But that was misleading, after reading pip-tools documentation I found that

"If pip-compile finds an existing requirements.txt file that fulfils the dependencies then no changes will be made, even if updates are available."

That was my mistake, generated the files again and made new builds using python 3.10 that worked as expected. Once again sorry for the mistake!

@tasn
Copy link
Member

tasn commented Mar 23, 2022

Should I make a release?

@tasn tasn merged commit e0010f2 into etesync:master Mar 23, 2022
@victor-rds
Copy link
Contributor Author

Yes, but to be honest, I think you should "redo" last release and keep the change-log as it is now

@tasn
Copy link
Member

tasn commented Mar 23, 2022

What do you mean by redo? I can't unrelease.

@victor-rds
Copy link
Contributor Author

Also this updates fixes 6 open CVEs, and stop comments like on #122 and #123

image

@tasn
Copy link
Member

tasn commented Mar 23, 2022

They don't actually apply to us except for the low one.

@victor-rds
Copy link
Contributor Author

What do you mean by redo? I can't unrelease.

I thought deleting the v0.8.1 tag would remove the current release, if not possible make v0.8.2 then, thanks!

They don't actually apply to us except for the low one.

Yeah I know, I read your comments, but paranoid people will annoy you no matter what, this way everyone is satisfied with the security theater

@tasn
Copy link
Member

tasn commented Mar 23, 2022

Oh yeah, 100%. :)

I have no problem with updating dependencies, I'm not against it. Just don't think it's a cause for such alarm.

I thought deleting the v0.8.1 tag would remove the current release, if not possible make v0.8.2 then, thanks!

We try not to rewrite history, so not change what's already released. So I'll just publish v0.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants