tests/test_evol.py: port assertions to python3.12. #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As first identified in [Debian bug #1058334] affecting ete3, since introduction of Python 3.12, a number of tests are failing with errors looking like: AttributeError: 'Test_Coretype_ArrayTable' object has no attribute 'assert_'. Did you mean: 'assertIn'? This is because the newer version of the unittest module of the standard library removed the use of deprecated assert_ function for other ones more meaningful, as documented in [Python 3.12 novelties]. It appears that there are still a few assert_ occurrences remaining in ete4 source code, so this patch modernizes them. [Debian bug #1058334]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1058334 [Python 3.12 novelties]: https://docs.python.org/3/whatsnew/3.12.html#id3 Signed-off-by: Étienne Mollier <emollier@debian.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As first identified in Debian bug #1058334 affecting ete3, since introduction of Python 3.12, a number of tests are failing with errors looking like:
This is because the newer version of the unittest module of the standard library removed the use of deprecated assert_ function for other ones more meaningful, as documented in Python 3.12 novelties. It appears that there are still a few assert_ occurrences remaining in ete4 source code, so this patch modernizes them.