Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate porting some lighting options from Q3e. #3

Open
ensiform opened this issue May 27, 2017 · 5 comments
Open

Investigate porting some lighting options from Q3e. #3

ensiform opened this issue May 27, 2017 · 5 comments
Labels
Origin: Quake3e Priority: Medium Status: In Progress Type: Enhancement Type: Reimplement ET Feature

Comments

@ensiform
Copy link
Member

Not sure how we want to have this yet.

As it stands vET light is different from vQ3 so there might need to be even more options to consider if we want to support both styles?
ensiform referenced this issue May 29, 2017
@ensiform
Upgraded more q3e files
df16522 
Added some PMLIGHTING (disabled)
Hopefully this fixes r_greyscale not fully working.
Removed redundant bypassing cd check print.
Adds dpi awareness (not fully working though it seems)
Fixup texture anisotropic filtering.
Add legacy master as new default master2.
ioq3->q3e fix for detail stages.
Add more information to gfxinfo output.
Update default g_gameType on game restarts.
Migrate ET profile system to game restarts. (Untested, as ETF doesn't use them)
@ensiform
Copy link
Member Author

ensiform commented Jun 2, 2017

It works now, but there is some descrepencies with ET specific features. ET model format so far not yet implemented for supporting r_dlightMode 2 and r_shadows 2.

Foliage doesn't seem to be affected.

ensiform added a commit that referenced this issue Jun 5, 2017
@ensiform
Update to latest PMLight changes using fbo and arb shaders
69aa44f 
Refs #3
@ensiform
Copy link
Member Author

ensiform commented Sep 8, 2017

I think this is basically done, but should still use some polish with mixing ET features and extensive ET testing. ETF obviously doesn't use most of these other than decals.

@ensiform
Copy link
Member Author

So, the pmlighting works okay for ETF because there isn't separate radius and intensity. The ET dlight code needs porting to the arb light passes to make them more complete.

@ensiform
Copy link
Member Author

Basic lighting is good to go.

ET changes are still unfinished:

  • Light Radius/Intensity is hackish only
  • Lightning on radar

@ensiform ensiform mentioned this issue Feb 6, 2019
Open
9 tasks
@ensiform
Copy link
Member Author

  • Properly handle separate radius and intensity instead of hacked in via RE_AddLightToScene\
  • Handle global directional dlights such as on radar causing lightning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Origin: Quake3e Priority: Medium Status: In Progress Type: Enhancement Type: Reimplement ET Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ensiform