Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively kill all RPC child processes on exit #1200

Merged
merged 2 commits into from Aug 16, 2021

Conversation

shuklaayush
Copy link
Contributor

@shuklaayush shuklaayush commented Aug 12, 2021

What I did

Modified the RPC kill() function to recursively kill all child processes. This ensures that hardhat terminates properly on exit.

Also changed timeout of hardhat-fork to 120s to match other forknets.

Related issue: #1199

How to verify it

# Launch brownie. This should launch a new hardhat instance
brownie console --network hardhat
# Terminate brownie. This should kill the active hardhat instance
quit()

# Relaunch brownie. Verify that it launches a new hardhat instance
brownie console --network hardhat

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have added an entry to the changelog

@iamdefinitelyahuman iamdefinitelyahuman merged commit 7f9226c into eth-brownie:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants