fix: unknown test when attempting to enter console #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix an unhandled exception when attempting to use
--interactiveand a test contains a syntax error.How I did it
If a test cannot be collected, it is not added to
node_mapwithin the runner. This results in aKeyErrorwhen trying to access the value to filter the local namespace.To fix it, I've added a check that the path is present in
node_mapprior to opening the console.How to verify it
Try to interactively debug a test with a syntax error. It still won't be possible, but you'll receive the correct exception.