Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue 945 #946

Merged
merged 1 commit into from Jan 31, 2021
Merged

fix: issue 945 #946

merged 1 commit into from Jan 31, 2021

Conversation

Macarse
Copy link
Contributor

@Macarse Macarse commented Jan 31, 2021

What I did

magic

Related issue: Fixes #945

How I did it

Printed implementation_eip1967 and implementation_eip1822 and saw:

implementation_eip1967: b''
implementation_eip1822: b''

No idea why they are empty now 馃し

How to verify it

Run weth = Contract("0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2")
Make sure you are running with a clean ~/.brownie folder.

iamdefinitelyahuman
iamdefinitelyahuman approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamdefinitelyahuman iamdefinitelyahuman merged commit 3520e28 into eth-brownie:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdefinitelyahuman iamdefinitelyahuman iamdefinitelyahuman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError: invalid literal for int() with base 16: '0x'
2 participants
@Macarse @iamdefinitelyahuman