This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
PR Reviews #16
Labels
Comments
soc1c
pushed a commit
that referenced
this issue
Aug 7, 2019
* Updates bootnodes * what a fantastic test :)
soc1c
added a commit
that referenced
this issue
Aug 7, 2019
* Fixed state transition logic for edge case (#17) * Update morden bootnodes (#16) * Updates bootnodes * what a fantastic test :) * Core execution refactor, EIP 684, edge case fixes, starting nonce for morden (#19) * Refactored Call * Refactored CallCode * Refactored DelegateCall * Refactored StaticCall * Added create before contract collision check * Refactored Call * Refactored CallCode * Refactored DelegateCall * Refactored StaticCall * Added create before contract collision check * Fixed state transition logic for edge case * Added create collision logic * Fix for edge case tests * Removed outdated contract collision tests and changed format of test output to be consistent * Rename exec function * utilize StartingNonce from state instead of explicit 0 nonce checks for contract collision and empty objects * Fixes morden seg fault edge case * adding starting nonce to created contracts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'd like to increase the threshold for PR review from 1 to 3.
That being said, I would like @noot to approve all PR's (for consistency) one of myself or @soc1c and third from any other contributor (@Aabell8, @dziabko, @steviezhang or @priom).
Rational
I would like that everyone on the team understands the on going changes to the code base.
The text was updated successfully, but these errors were encountered: