Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: create new genesis for holesky #73

Merged
merged 5 commits into from Sep 19, 2023
Merged

Fix: create new genesis for holesky #73

merged 5 commits into from Sep 19, 2023

Conversation

barnabasbusa
Copy link
Collaborator

No description provided.

@barnabasbusa barnabasbusa changed the title Bbusa/remove extra data Fix: create new genesis for holesky Sep 15, 2023
rolfyone
rolfyone approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfyone rolfyone mentioned this pull request Sep 15, 2023
Closed
michaelsproul
michaelsproul reviewed Sep 16, 2023
View reviewed changes
README.md
@@ -12,40 +12,18 @@ This is _work in progress_. The final config will be shared prior to launch date
* Status: _Planned_ ([#3](https://github.com/eth-clients/holesky/issues/3))
* Flag: `--holesky`
* Flavor: Permissionless (Proof-of-Stake), _to replace Goerli_
* Launch Date: **Sept/15, 2023, 14:00 UTC**
* Epoch time: 1694786400
* Launch Date: **Sept/28, 2023, 12:00 UTC**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time suits the Australians & Kiwis a lot better than 14:00UTC. And Thursday is better than Friday as it gives a bit of a buffer to fix things before the weekend 👍

hwwhww
hwwhww reviewed Sep 16, 2023
View reviewed changes
custom_config_data/config.yaml
# Sep-28-2023 11:55:00 +UTC
# This is an invalid valid and should be updated when you create the genesis
MIN_GENESIS_TIME: 1695902100
GENESIS_FORK_VERSION: 0x01017000
Copy link

@hwwhww hwwhww Sep 16, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱😱😱
then we will have to update deposit-cli for it.

@barnabasbusa
Is there also a new genesis_validators_root?

/cc @CarlBeek

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The genesis_validators_root is 0x9143aa7c615a7f7115e2b6aac319c03529df8242ae705fba9df39b79c59fa8b1

@michaelsproul michaelsproul mentioned this pull request Sep 18, 2023
Closed
prestonvanloon added a commit to prysmaticlabs/prysm that referenced this pull request Sep 18, 2023
@prestonvanloon
Update holesky config with new genesis. See eth-clients/holesky#73
eaa92e6
@prestonvanloon prestonvanloon mentioned this pull request Sep 18, 2023
Merged
prestonvanloon added a commit to prysmaticlabs/prysm that referenced this pull request Sep 18, 2023
@prestonvanloon
Update holesky config with new genesis. See eth-clients/holesky#73
0fbfe6b
prestonvanloon
prestonvanloon approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Prysm is no longer complaining about missing genesis block and appears ready to launch holesky with the configs from this PR.

@rolfyone
Copy link
Contributor

can we merge and start releasing?

@siladu siladu mentioned this pull request Sep 18, 2023
Merged
siladu
siladu reviewed Sep 18, 2023
View reviewed changes
Copy link

@siladu siladu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to incorporate these besu config issues first #72.

Couple of questions I want to clarify, maybe I missed some discussion about this:

  1. The new genesis epoch time is 1695902400 but the EL genesis timestamp is 1695902100 (5 mins before). Just wondering why we need that 5 minutes?

  2. Why can't we start with shanghai/capella at genesis?

@parithosh
Copy link
Member

parithosh commented Sep 18, 2023 •
edited

Besu needs to incorporate #72 first.

Couple of questions I want to clarify, maybe I missed some discussion about this:

1. The new genesis epoch time is 1695902400 but the EL genesis timestamp is 1695902100 (5 mins before). Just wondering why we need that 5 minutes?

2. Why can't we start with shanghai/capella at genesis?

Yup, waiting on Barnabas to merge in changes from #72 , context: #72 (comment)

  1. The generation tool just auto sets the CL config's MIN_GENESIS_TIME as the EL genesis timestamp. We can change that to MIN_GENESIS_TIME + GENESIS_DELAY which is when the CL will have genesis, but it shouldn't play a role as the EL is just basically ready for duties and waits around until the CL sends it the required messages - Would loosely prefer not changing the value for now unless there's a reason to do so
  2. We haven't tested capella genesis in any devnet yet(devnet-9 will be the first), we only have tested it in some local testnets and weren't comfortable with testing it publically for the first time at such a huge scale. That's why we opted to suggest bellatrix genesis and a capella fork a day later.

@michaelsproul michaelsproul mentioned this pull request Sep 19, 2023
Closed
@siladu
Copy link

siladu commented Sep 19, 2023

Can any other EL teams confirm this is the ForkId for Holesky at genesis?

ForkId(0xc61a6098, 1696000704)
and then after Shanghai...
ForkId(0xfd4f016b, 0)

@parithosh parithosh mentioned this pull request Sep 19, 2023
Closed
@parithosh parithosh mentioned this pull request Sep 19, 2023
Closed
siladu
siladu approved these changes Sep 19, 2023
View reviewed changes
Copy link

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parithosh parithosh merged commit f1d14b9 into main Sep 19, 2023
@parithosh parithosh deleted the bbusa/remove-extraData branch September 19, 2023 21:01
@nflaig nflaig mentioned this pull request Sep 20, 2023
Merged
@smartprogrammer93 smartprogrammer93 mentioned this pull request Sep 20, 2023
Merged
12 tasks
@g11tech g11tech mentioned this pull request Sep 20, 2023
Merged
@g11tech
Copy link
Contributor

g11tech commented Sep 20, 2023

Can any other EL teams confirm this is the ForkId for Holesky at genesis?

ForkId(0xc61a6098, 1696000704) and then after Shanghai... ForkId(0xfd4f016b, 0)

yes i can confim the same 🙂

@nflaig nflaig mentioned this pull request Sep 20, 2023
Merged
prylabs-bulldozer bot added a commit to prysmaticlabs/prysm that referenced this pull request Sep 23, 2023
@prestonvanloon @prylabs-bulldozer
Update holesky config for new genesis (#12919)
57a63f3 
* Update holesky config with new genesis. See eth-clients/holesky#73

* Update bootnodes

* Update bootnodes

* Use latest commit

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
@hwwhww hwwhww mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul left review comments

@hwwhww hwwhww hwwhww left review comments

@parithosh parithosh parithosh left review comments

@siladu siladu siladu approved these changes

@rolfyone rolfyone rolfyone approved these changes

@prestonvanloon prestonvanloon prestonvanloon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@barnabasbusa @rolfyone @parithosh @siladu @g11tech @michaelsproul @prestonvanloon @hwwhww