Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #8

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Add documentation #8

wants to merge 14 commits into from

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented May 22, 2024

  • Close Add documentation #7
  • Add GitHub Action to automatically deploy documentation on the gh-pages branch

Documentation Preview

The documentation is currently incomplete: only one function per algorithm is documented, plus the helper functions. It will be completed once the phrasing is agreed upon.

@RMeli RMeli added the documentation Improvements or additions to documentation label May 22, 2024
@RMeli RMeli self-assigned this May 22, 2024
Comment on lines +13 to +17
on:
- push
# push:
# branches:
# - main
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be fixed before merging.

* [ETH Zurich]: Swiss Federal Institute of Technology Zurich
* [PASC]: Platform for Advanced Scientific Computing

<img height="50" src="./docs/images/logo-cscs.jpg"><img height="50" src="./docs/images/logo-eth.svg"><img height="50" src="./docs/images/logo-pasc.png">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require assets added in #6

@rasolca
Copy link
Collaborator

rasolca commented May 24, 2024

Preliminary questions:
Is the doc already available somewhere?
Any plan to keep the documentation of released versions?

@RMeli
Copy link
Member Author

RMeli commented May 24, 2024

Is the doc already available somewhere?

There is a preview from my fork: https://rmeli.github.io/DLA-Future-Fortran

Any plan to keep the documentation of released versions?

Not really... I'm open to suggestions.

project: DLA-Future-Fortran
summary: Fortan interface for DLA-Future
project_github: https://github.com/eth-cscs/DLA-Future-Fortran
author: Rocco Meli
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add everyone (or remove).

@RMeli RMeli marked this pull request as ready for review May 24, 2024 10:34
@RMeli RMeli marked this pull request as draft May 24, 2024 10:58
Comment on lines +77 to +88
## Optimal parameters

### Block size

| Device | Block size |
| :----: | :--------: |
| CPU | 512 |
| GPU | 1024 |

### Ranks per node

For CPU-only calculations it is recommended to use one rank per NUMA domain. For GPU calculations it is recommended to use one rank per GPU.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is something we could put in DLA-Future's documentation instead and link to it from here? Additionally, I'd add some sort of disclaimer for the block sizes that these are typically the best sizes, but YMMV etc. etc. i.e do your own tests if you want "optimal parameters".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, adding this directly in DLA-Future's documentation would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation
4 participants