Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of setuptools installation #11

Closed
remyroy opened this issue Apr 17, 2024 · 1 comment · Fixed by #28
Closed

Remove the use of setuptools installation #11

remyroy opened this issue Apr 17, 2024 · 1 comment · Fixed by #28
Assignees
Labels
enhancement New feature or request

Comments

@remyroy
Copy link
Member

remyroy commented Apr 17, 2024

Using python setup.py install with setuptools is deprecated. It should be removed and replaced with something else. This might give us the opportunity to remove the setuptools dependency entirely. See https://pip.pypa.io/en/stable/topics/secure-installs/#do-not-use-setuptools-directly

This can be found at least in https://github.com/eth-educators/ethstaker-deposit-cli/blob/main/deposit.sh#L8

@remyroy remyroy added the enhancement New feature or request label Apr 17, 2024
@remyroy remyroy self-assigned this Apr 25, 2024
@remyroy
Copy link
Member Author

remyroy commented Apr 25, 2024

Setuptools is not needed since we are not distributing this as a Python package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant