AA-345: Change "magic" size to 20 bytes as a placeholder for future aggregation RIP #8
Conversation
|
|
||
| abi.encode(context, MAGIC_VALUE_PAYMASTER, validUntil, validAfter) | ||
|
|
||
| MAGIC_VALUE_PAYMASTER <20 bytes>, validUntil <6 bytes>, validAfter <6 bytes>, 64 <constant, 32 bytes>, length <32 bytes>, context <variable> |
There was a problem hiding this comment.
I think at this point there is no benefit in "truncating" the magic value to 20 bytes (because we expect an address there sometime in the future) and we should just give it 32 bytes. Makes it much easier to return the values in Solidity.
There was a problem hiding this comment.
at this point all wallets are 4337, which means they already do it.
we either returns( bytes32 validationData ) (which is a packing of after/until/magic)
or returns (uint256 magic, uint256 validAfter, uint256 validUntil)
(and an extra bytes context for paymaster)
There was a problem hiding this comment.
returns (uint256 magic, uint256 validAfter, uint256 validUntil)(and an extrabytes contextfor paymaster)
I think this would be much better and won't actually cost more than the packed version. I strongly suggest we consider doing exactly this and returning each variable with a native 256-bit value instead of shifting, packing and so on.
|
|
||
| Same as in the [`sender` validation frame](#sender-validation-frame), in order to support gas estimation this | ||
| frame should return a value different from `MAGIC_VALUE_PAYMASTER` for conditions that cannot be satisfied | ||
| before signing. | ||
| frame should revert on errors, but return `MAGIC_VALUE_SIGFAIL` if the failure is because of signing error. |
There was a problem hiding this comment.
"in order to support gas estimation this frame should return MAGIC_VALUE_SIGFAIL if the failure is only caused by a signature verification error. This frame can revert in case of other exceptions." Something like that?
There was a problem hiding this comment.
I still think this phrase could be rephrased to be clearer.
forshtat
changed the title
No description provided.