AA-128 L-09: document getBlsPublicKey #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove confusing reference to non-existent (and non-standard) method getAggregationInfo() give "getBlsPublicKey" as an example.
forshtat
reviewed
Feb 5, 2023
| @@ -145,9 +145,10 @@ interface IAggregatedAccount is IAccount { | |||
|
|
|||
| * **getAggregator()** returns the aggregator this account supports. | |||
| * **validateUserOp()** (inherited from IAccount interface) MUST verify the `aggregator` parameter is valid and the same as `getAggregator` | |||
| * The account should also support aggregator-specific getter (e.g. `getAggregationInfo()`). | |||
| * The account should also support aggregator-specific getter. | |||
There was a problem hiding this comment.
Maybe this is better left out of the ERC, like the aggregator and the account interaction is not restricted by this ERC. The account may need to support aggregator-specific view functions. or something along this line?
add missing require message. Note that account's addDeposit() now calls the paymaster's depositTo() explicitly, instead of relying on the EntryPoint's receive() fallback method.
shahafn
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove confusing reference to non-existent (and non-standard) method getAggregationInfo()
give "getBlsPublicKey" as an example.