Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current master fails tests on use_shim with macOS bash (3.2.57) #26

Closed
lilyball opened this issue May 2, 2020 · 2 comments
Closed

Current master fails tests on use_shim with macOS bash (3.2.57) #26

lilyball opened this issue May 2, 2020 · 2 comments
Assignees
@eth-p
Labels
bug Something isn't working

Comments

@lilyball
Copy link

lilyball commented May 2, 2020

Running the tests on current master (fb97300)fails on Bash 3.2.57 (what macOS ships with). For each test suite I get an error in grey (test runner?) aboutuse_shim: command not found, and then the test suite itself logs a bunch of errors about description: command not found` (I don't know if this is a consequence of use_shim missing, or is the same underlying cause, or what). Running them with Bash 4.4.23 instead works fine.

Output with bash 3.2.57 
-----------------------------------------------------------------------------------------------------------
| Test Suite: batdiff                                                                                     |
-----------------------------------------------------------------------------------------------------------
/Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batdiff.sh: line 2: use_shim: command not found
FATAL ERROR: The test runner has crashed.
failed with exit code 127
-----------------------------------------------------------------------------------------------------------
| Test Suite: batgrep                                                                                     |
-----------------------------------------------------------------------------------------------------------
/Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batgrep.sh: line 4: use_shim: command not found
[FAIL] option_context       :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batgrep.sh: line 87: description: command not found
[FAIL] output_with_color    :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batgrep.sh: line 47: description: command not found
[FAIL] output_without_color :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batgrep.sh: line 57: description: command not found
[FAIL] regular_file         :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batgrep.sh: line 27: description: command not found
[FAIL] search_fixed         :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batgrep.sh: line 77: description: command not found
[FAIL] search_regex         :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batgrep.sh: line 67: description: command not found
[FAIL] symlink_file         :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batgrep.sh: line 37: description: command not found
[FAIL] version              :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batgrep.sh: line 18: description: command not found

Totals:
    PASS: 0 / 8
    FAIL: 8 / 8
-----------------------------------------------------------------------------------------------------------
| Test Suite: batman                                                                                      |
-----------------------------------------------------------------------------------------------------------
/Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batman.sh: line 2: use_shim: command not found
FATAL ERROR: The test runner has crashed.
failed with exit code 127
-----------------------------------------------------------------------------------------------------------
| Test Suite: batwatch                                                                                    |
-----------------------------------------------------------------------------------------------------------
/Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/batwatch.sh: line 2: use_shim: command not found
FATAL ERROR: The test runner has crashed.
failed with exit code 127
-----------------------------------------------------------------------------------------------------------
| Test Suite: lib_dsl                                                                                     |
-----------------------------------------------------------------------------------------------------------
[FAIL] parse_command        :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_dsl.sh: line 59: description: command not found
[FAIL] parse_escaped_args   :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_dsl.sh: line 83: description: command not found
[FAIL] parse_option         :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_dsl.sh: line 92: description: command not found
[FAIL] parse_quoted_args    :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_dsl.sh: line 75: description: command not found
[FAIL] parse_simple_args    :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_dsl.sh: line 67: description: command not found

Totals:
    PASS: 0 / 5
    FAIL: 5 / 5
-----------------------------------------------------------------------------------------------------------
| Test Suite: lib_opt                                                                                     |
-----------------------------------------------------------------------------------------------------------
[FAIL] long                 :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_opt.sh: line 23: description: command not found
[FAIL] long_value_explicit  :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_opt.sh: line 50: description: command not found
[FAIL] long_value_implicit  :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_opt.sh: line 36: description: command not found
[FAIL] short_value_explicit :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_opt.sh: line 78: description: command not found
[FAIL] short_value_implicit :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_opt.sh: line 64: description: command not found

Totals:
    PASS: 0 / 5
    FAIL: 5 / 5
-----------------------------------------------------------------------------------------------------------
| Test Suite: lib_pager                                                                                   |
-----------------------------------------------------------------------------------------------------------
[FAIL] args_copied_from_bat_pager :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_pager.sh: line 94: description: command not found
[FAIL] args_copied_from_pager :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_pager.sh: line 86: description: command not found
[FAIL] env_bat_pager        :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_pager.sh: line 74: description: command not found
[FAIL] less_args            :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_pager.sh: line 44: description: command not found
[FAIL] less_args_not_less   :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_pager.sh: line 66: description: command not found
[FAIL] less_detection       :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_pager.sh: line 22: description: command not found
[FAIL] less_version         :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_pager.sh: line 30: description: command not found

Totals:
    PASS: 0 / 7
    FAIL: 7 / 7
-----------------------------------------------------------------------------------------------------------
| Test Suite: lib_version                                                                                 |
-----------------------------------------------------------------------------------------------------------
[FAIL] compare_eq           :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_version.sh: line 6: description: command not found
[FAIL] compare_ge           :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_version.sh: line 56: description: command not found
[FAIL] compare_gt           :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_version.sh: line 36: description: command not found
[FAIL] compare_le           :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_version.sh: line 46: description: command not found
[FAIL] compare_lt           :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_version.sh: line 26: description: command not found
[FAIL] compare_ne           :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/lib_version.sh: line 16: description: command not found

Totals:
    PASS: 0 / 6
    FAIL: 6 / 6
-----------------------------------------------------------------------------------------------------------
| Test Suite: perf                                                                                        |
-----------------------------------------------------------------------------------------------------------
[FAIL] perf_baseline        :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 6: description: command not found
[FAIL] perf_lib_constants   :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 11: description: command not found
[FAIL] perf_lib_dsl         :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 17: description: command not found
[FAIL] perf_lib_opt         :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 23: description: command not found
[FAIL] perf_lib_opt_hook_color :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 29: description: command not found
[FAIL] perf_lib_opt_hook_pager :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 35: description: command not found
[FAIL] perf_lib_opt_hook_version :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 41: description: command not found
[FAIL] perf_lib_opt_hook_width :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 47: description: command not found
[FAIL] perf_lib_pager       :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 53: description: command not found
[FAIL] perf_lib_print       :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 59: description: command not found
[FAIL] perf_lib_str         :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 65: description: command not found
[FAIL] perf_lib_version     :: /Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/perf.sh: line 71: description: command not found

Totals:
    PASS: 0 / 12
    FAIL: 12 / 12
-----------------------------------------------------------------------------------------------------------
| Test Suite: prettybat                                                                                   |
-----------------------------------------------------------------------------------------------------------
/Users/lily/Dev/Nix/Scratch/bat-extras/test/suite/prettybat.sh: line 2: use_shim: command not found
FATAL ERROR: The test runner has crashed.
failed with exit code 127
@eth-p eth-p mentioned this issue May 2, 2020
Closed
@eth-p eth-p self-assigned this May 2, 2020
@eth-p eth-p added the bug Something isn't working label May 2, 2020
@eth-p
Copy link
Owner

eth-p commented May 2, 2020

Thanks for letting me know. I just pushed a fix for this, can you let me know if it solves the issue for you?

@lilyball
Copy link
Author

lilyball commented May 4, 2020

Current master (5af706f) successfully passes the test suite on macOS when using ./test.sh.

@lilyball lilyball closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eth-p eth-p

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lilyball @eth-p