Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Browserify and Webpack partly #8

Merged
merged 5 commits into from
Jun 11, 2020

Conversation

Heath123
Copy link
Contributor

Fixes #7, but not #6 because my fix probably for that isn't the best solution

This reverts commit 26a8757.
Fixes ethanent#7, but not ethanent#6 because my fix probably for that isn't the best solution
@Heath123 Heath123 changed the title Fix browserify partly Fix Browserify and Webpack partly Apr 25, 2020
@ethanent ethanent merged commit 5600d17 into ethanent:master Jun 11, 2020
@ethanent
Copy link
Owner

ethanent commented Jun 11, 2020

This is good. It seems like null is sometimes used as the value for URL.search if a URL without a querystring is parsed using the url.parse method.

I also created a PR to update Node URL module documentation, so we will see what people think: nodejs/node#33849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browserify/Webpack: null appended to URL
2 participants