Skip to content
This repository has been archived by the owner on Mar 12, 2023. It is now read-only.

Changed Header and payload to current API #9

Closed
wants to merge 5 commits into from
Closed

Changed Header and payload to current API #9

wants to merge 5 commits into from

Conversation

doozMen
Copy link

@doozMen doozMen commented Dec 28, 2018

I guess it was different before. Added some keys and now it works for me at least.

@ethanhuang13
Copy link
Owner

ethanhuang13 commented Dec 29, 2018

Please separate each commit to different PRs.

Also, the keys are for APNs and DeviceCheck. Please add another file for App Store Connect API instead.

@ethanhuang13
Copy link
Owner

Close the PR because you should separate each commit to different PRs.

@doozMen
Copy link
Author

doozMen commented Jan 16, 2019

@ethanhuang13 closing a pr because each commit needs to be a PR is not really a reason. Also what I did actually works and is needed. So I will look into it but I tried to help you. Why the defence?

@doozMen
Copy link
Author

doozMen commented Jan 16, 2019

Please separate each commit to different PRs.

Also, the keys are for APNs and DeviceCheck. Please add another file for App Store Connect API instead.

Thanks for this comment but. I will change this in issue #10

@ethanhuang13
Copy link
Owner

@ethanhuang13 closing a pr because each commit needs to be a PR is not really a reason. Also what I did actually works and is needed. So I will look into it but I tried to help you. Why the defence?

"fix signing"(4bd3669) is not a fix, you've just change to what you need(manual) and its not related to App Store Connect API. These three commits 3c49575, 99728e1, and 9f09752 have the same situation.

If you separate them as different PRs, I can accept them.

@doozMen
Copy link
Author

doozMen commented Jan 16, 2019

@ethanhuang13 I have read your ReadMe and also the link to the article related to the commits. Interesting point of view. I will read it and make it better. Just I thought this was already a small PR. Also I made a mistake in thinking your frameworks was only for App Store Connect. It is not so I will change that. So I was a bit quick in asking why you rejected, sorry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants