Make sure stale shop data isn't shown when opening new shop after pre…

…vious shop has been opened
ethanmoffat · Apr 5, 2022 · 89f6d9a · 89f6d9a
1 parent 5f4eda4
commit 89f6d9a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/EOLib/Domain/Interact/Shop/ShopDataRepository.cs b/EOLib/Domain/Interact/Shop/ShopDataRepository.cs
@@ -3,7 +3,7 @@
 
 namespace EOLib.Domain.Interact.Shop
 {
-    public interface IShopDataRepository
+    public interface IShopDataRepository : IResettable
     {
         int ShopID { get; set; }
 
@@ -14,7 +14,7 @@ public interface IShopDataRepository
         List<IShopCraftItem> CraftItems { get; set; }
     }
 
-    public interface IShopDataProvider
+    public interface IShopDataProvider : IResettable
     {
         int ShopID { get; }
 
@@ -26,7 +26,7 @@ public interface IShopDataProvider
     }
 
     [AutoMappedType(IsSingleton = true)]
-    public class ShopDataRepository : IShopDataProvider, IShopDataRepository, IResettable
+    public class ShopDataRepository : IShopDataProvider, IShopDataRepository
     {
         public int ShopID { get; set; }
         public string ShopName { get; set; }

diff --git a/EndlessClient/Dialogs/Actions/InGameDialogActions.cs b/EndlessClient/Dialogs/Actions/InGameDialogActions.cs
@@ -1,6 +1,7 @@
 using AutomaticTypeMapper;
 using EndlessClient.Dialogs.Factories;
 using EOLib.Domain.Character;
+using EOLib.Domain.Interact.Shop;
 using Optional;
 
 namespace EndlessClient.Dialogs.Actions
@@ -11,16 +12,19 @@ public class InGameDialogActions : IInGameDialogActions
         private readonly IFriendIgnoreListDialogFactory _friendIgnoreListDialogFactory;
         private readonly IPaperdollDialogFactory _paperdollDialogFactory;
         private readonly IActiveDialogRepository _activeDialogRepository;
+        private readonly IShopDataRepository _shopDataRepository;
         private readonly IShopDialogFactory _shopDialogFactory;
 
         public InGameDialogActions(IFriendIgnoreListDialogFactory friendIgnoreListDialogFactory,
                                    IPaperdollDialogFactory paperdollDialogFactory,
                                    IActiveDialogRepository activeDialogRepository,
+                                   IShopDataRepository shopDataRepository,
                                    IShopDialogFactory shopDialogFactory)
         {
             _friendIgnoreListDialogFactory = friendIgnoreListDialogFactory;
             _paperdollDialogFactory = paperdollDialogFactory;
             _activeDialogRepository = activeDialogRepository;
+            _shopDataRepository = shopDataRepository;
             _shopDialogFactory = shopDialogFactory;
         }
 
@@ -65,7 +69,11 @@ public void ShowShopDialog()
             _activeDialogRepository.ShopDialog.MatchNone(() =>
             {
                 var dlg = _shopDialogFactory.Create();
-                dlg.DialogClosed += (_, _) => _activeDialogRepository.ShopDialog = Option.None<ShopDialog>();
+                dlg.DialogClosed += (_, _) =>
+                {
+                    _activeDialogRepository.ShopDialog = Option.None<ShopDialog>();
+                    _shopDataRepository.ResetState();
+                };
                 _activeDialogRepository.ShopDialog = Option.Some(dlg);
 
                 dlg.Show();